fix(typing): Replace typing_extensions imports with standard typing i…#37
Merged
fix(typing): Replace typing_extensions imports with standard typing i…#37
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request modernizes type hint imports by replacing typing_extensions with the standard library typing module. Since the project requires Python 3.12+, all the type constructs previously imported from typing_extensions (Literal, TypedDict, and override) are now available in the standard library, eliminating the need for the external package.
- Consolidated imports from
typing_extensionsto the standardtypingmodule - Updated three files to use modern Python 3.12+ typing features
- Maintained proper import ordering and code style consistency
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| veaiops/utils/kb.py | Moved override import from typing_extensions to standard typing module |
| veaiops/metrics/timeseries.py | Replaced TypedDict import with standard library version |
| veaiops/metrics/base.py | Moved Literal import from typing_extensions to standard typing module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates type imports throughout the codebase to improve compatibility and adhere to modern Python standards. The main change is replacing imports from
typing_extensionswith imports from the standard library'stypingmodule where appropriate.Type import modernization:
Literalimport fromtyping_extensionswithLiteralfrom the standard librarytypinginveaiops/metrics/base.py.TypedDictimport fromtyping_extensionswithTypedDictfrom the standard librarytypinginveaiops/metrics/timeseries.py.overrideimport fromtyping_extensionswithoverridefrom the standard librarytypinginveaiops/utils/kb.py.…mports